kushidou/hugo-theme-stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: check if paragraph exists before accessing it's textContent

Browse Source 
closes https://github.com/CaiJimmy/hugo-theme-stack/issues/490
This commit is contained in:
Jimmy Cai
2022-02-12 13:23:38 +00:00
committed by GitHub
parent 4b0dbb4630
commit 0fbbc12949
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
assets/ts/gallery.ts
+2
View File
@@ -67,6 +67,8 @@ class StackGallery {
/// This is done to allow inline images within paragraphs /// This is done to allow inline images within paragraphs
const paragraph = img.closest('p'); const paragraph = img.closest('p');
if (!paragraph || !container.contains(paragraph)) continue;
if (paragraph.textContent.trim() == '') { if (paragraph.textContent.trim() == '') {
/// Once we insert figcaption, this check no longer works /// Once we insert figcaption, this check no longer works
/// So we add a class to paragraph to mark it /// So we add a class to paragraph to mark it