From 78800c7379e6ece51ac6d31b2ee049d2d40801e3 Mon Sep 17 00:00:00 2001
From: Jimmy <jimmy@cai.im>
Date: Wed, 4 Mar 2026 13:05:17 +0100
Subject: [PATCH] fix: keep external image url, and use
 reflect.IsImageResourceProcessable to check for svg and other non-processable
 image formats (#1282)

* fix: keep external image url, and use reflect.IsImageResourceProcessable to check for svg

* build: update Hugo version to 0.157.0 in the build script.

* docs: remove `Local` return value and simplify `Resource` description in image helper

* Check for reflect.IsImageResourceProcessable before getting color from image

* chore: update minimum Hugo version to 0.157.0
---
 .ci/build.sh                             |  2 +-
 config/_default/module.toml              |  2 +-
 layouts/_partials/article-list/tile.html |  2 +-
 layouts/_partials/helper/image.html      | 33 ++++++++++++------------
 theme.toml                               |  2 +-
 5 files changed, 21 insertions(+), 20 deletions(-)

diff --git a/.ci/build.sh b/.ci/build.sh
index 06ff728..2859088 100644
--- a/.ci/build.sh
+++ b/.ci/build.sh
@@ -10,7 +10,7 @@
 main() {
   DART_SASS_VERSION=1.97.1
   GO_VERSION=1.25.5
-  HUGO_VERSION=0.156.0
+  HUGO_VERSION=0.157.0
   NODE_VERSION=24.12.0
 
   export TZ=Europe/Oslo
diff --git a/config/_default/module.toml b/config/_default/module.toml
index 8ccccf2..3e283b5 100644
--- a/config/_default/module.toml
+++ b/config/_default/module.toml
@@ -1,3 +1,3 @@
 [hugoVersion]
     extended = true
-    min      = "0.154.0"
+    min      = "0.157.0"
diff --git a/layouts/_partials/article-list/tile.html b/layouts/_partials/article-list/tile.html
index 5f03dd4..3c819b2 100644
--- a/layouts/_partials/article-list/tile.html
+++ b/layouts/_partials/article-list/tile.html
@@ -9,7 +9,7 @@
         {{ end }}
 
         <div class="article-details"
-            {{- if and $image $image.Resource -}}
+            {{- if and $image (reflect.IsImageResourceProcessable $image.Resource) -}}
                 {{- $colors := $image.Resource.Colors -}}
                 {{- if $colors -}}
                     {{- $vibrant := index $colors 0 -}}
diff --git a/layouts/_partials/helper/image.html b/layouts/_partials/helper/image.html
index 19182ac..fce9d04 100644
--- a/layouts/_partials/helper/image.html
+++ b/layouts/_partials/helper/image.html
@@ -3,8 +3,7 @@
 ///     Image: Image URL
 
 /// Returns:
-///     Local: true if the image is local, false if it is remote
-///     Resource: Hugo image resource object, not nil if the image is local
+///     Resource: Hugo image resource object
 ///     Permalink: Image URL
 ///     Height: Image height
 ///     Width: Image width
@@ -13,10 +12,15 @@
 
 {{ if .Image }}
     {{ $url := urls.Parse .Image }}
+    {{ $permalink := .Image }}
     {{ $resource := "" }}
+
     {{ if not (in (slice "https" "http") $url.Scheme) }}
+        {{/* Local image */}}
         {{ $resource = .Resources.Get (printf "%s" (.Image | safeURL)) }}
+        {{ $permalink = $resource.RelPermalink }}
     {{ else }}
+        {{/* Remote image */}}
         {{ with try (resources.GetRemote $url) }}
             {{ with .Err }}
                 {{ errorf "%s" . }}
@@ -28,25 +32,22 @@
         {{ end }}   
     {{ end }}
 
-    {{ if $resource }}
-        {{- $isSVG := eq $resource.MediaType.SubType "svg"  -}}
-        {{- if $isSVG -}}
+    {{ with $resource }}
+        {{ if reflect.IsImageResourceProcessable . }}
             {{ $result = dict
-                "Local" true
                 "Resource" $resource
-                "Permalink" $resource.RelPermalink
-                "Height" nil
-                "Width" nil
-            }}
-        {{- else -}}            
-            {{- $result = dict
-                "Local" true
-                "Resource" $resource
-                "Permalink" $resource.RelPermalink
+                "Permalink" $permalink
                 "Height" $resource.Height
                 "Width" $resource.Width
             }}
-        {{- end -}}
+        {{ else }}
+            {{ $result = dict
+                "Resource" $resource
+                "Permalink" $permalink
+                "Height" nil
+                "Width" nil
+            }}
+        {{ end }}
     {{ end }}
 {{ end }}
 
diff --git a/theme.toml b/theme.toml
index 5dfce66..f926a59 100644
--- a/theme.toml
+++ b/theme.toml
@@ -20,7 +20,7 @@ features = [
     "search",
 ]
 
-min_version = "0.154.0"
+min_version = "0.157.0"
 
 [author]
     name     = "Jimmy Cai"